fix: tune Dependabot config and fix DCO assistant bugs#534
fix: tune Dependabot config and fix DCO assistant bugs#534andreatgretel merged 4 commits intomainfrom
Conversation
The Dependabot config added in #517 included weekly version-bump PRs for all three pip packages. This would generate noisy PRs for routine dep updates we don't need. Set open-pull-requests-limit: 0 on the pip ecosystems so only CVE-triggered security updates open PRs. GitHub Actions weekly bumps are kept as-is to keep SHA pins current.
Code Review: PR #534 — fix: restrict Dependabot pip updates to security-onlySummaryThis PR adds Scope: 1 file changed, 3 lines added, 0 lines deleted. FindingsCorrectness
Consistency
Commit hygiene
Minor observations
Potential concerns
VerdictApprove. This is a clean, correct configuration fix that reduces PR noise without sacrificing security coverage. No issues found. |
Greptile SummaryThis PR suppresses noisy Dependabot version-bump PRs for the three pip ecosystems by setting
|
| Filename | Overview |
|---|---|
| .github/dependabot.yml | Adds open-pull-requests-limit: 0 to all three pip ecosystems, correctly disabling version-bump PRs while leaving security update PRs unaffected (security updates are a separate GitHub feature not governed by this key). |
| .github/workflows/dco-assistant.yml | New DCO assistant workflow using pull_request_target (standard pattern for DCO tools that need write permissions); action is pinned to a commit SHA; permissions are explicitly scoped; dependabot[bot] is allowlisted. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Dependabot weekly schedule fires] --> B{Update type?}
B -->|Version update| C[open-pull-requests-limit: 0]
C --> D[No PR opened ✓]
B -->|Security advisory detected| E[GitHub Advisory Database]
E --> F[Security update PR opened ✓]
G[GitHub Actions ecosystem] --> H[SHA-pin bump PR opened weekly ✓]
Reviews (4): Last reviewed commit: "fix: align DCO assistant if-condition wi..." | Re-trigger Greptile
- Add a Dependabot group to bundle all GitHub Actions updates into a single weekly PR instead of one per action - Fix DCO allowlist: dependabot -> dependabot[bot] to match the actual GitHub username (the old value never matched, but there were no Dependabot PRs before #517 to expose the bug)
The step's if-condition checked for the default sign-off text but custom-pr-sign-comment uses different wording. This meant the issue_comment trigger was always skipped - sign-offs only worked by accident when a subsequent push re-triggered the action via pull_request_target.
Summary
Follow-up to #517 (CI supply chain hardening). Tunes the Dependabot configuration and fixes two pre-existing bugs in the DCO assistant workflow.
Changes
Changed
.github/dependabot.yml— setopen-pull-requests-limit: 0on all three pip ecosystems (security-only PRs), addgroups.all-actionsto bundle GitHub Actions bumps into a single weekly PRFixed
.github/workflows/dco-assistant.yml— fixallowlist: dependabot→allowlist: dependabot[bot]to match the actual GitHub bot username (never matched before, but no Dependabot PRs existed pre-chore: harden CI supply chain #517).github/workflows/dco-assistant.yml#L29— align the stepifcondition with thecustom-pr-sign-commenttext so theissue_commenttrigger actually fires when a new contributor signs the DCO via comment (previously only worked by accident when a subsequent push re-triggered the action viapull_request_target)Attention Areas
dco-assistant.yml— theifcondition andallowlistchanges affect how the DCO check runs for new contributors and bot PRsDescription updated with AI